Skip to content

Conversation

@jgebal
Copy link
Member

@jgebal jgebal commented May 23, 2019

Resolves #925
Resolves #927

@jgebal jgebal added the bugfix label May 23, 2019
@jgebal jgebal added this to the v3.1.7 milestone May 23, 2019
@jgebal jgebal self-assigned this May 23, 2019
@jgebal
Copy link
Member Author

jgebal commented May 25, 2019

@lwasylow I've replaced the test results failures with escaped CDATA blocks.
This is to avid the issue I've seen at work (quite rare but still annoying), where if failure message is longer than 4k an dbms_xmlgen.convert is used, the line can get split into two lines inside the escaped XML characters making the XML report impossible to parse.

Let me know if you're OK with this change.

@jgebal
Copy link
Member Author

jgebal commented May 25, 2019

Seems like sonar is complaining on code duplication.
Maybe we should have some base XML functions to avoid duplication?

@lwasylow
Copy link
Member

Yeah definitely change make sense. And I think moving some of duplicate code into utils type is a good idea. Less maintenance and possibility of bugs.

@jgebal jgebal merged commit 5b8f7bd into develop Jun 2, 2019
@jgebal jgebal deleted the feature/fix_sonar_test_reporter branch June 2, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JUnit test results import fail Sonar test results fail on import.

3 participants