Skip to content

Standalone coverage #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jgebal merged 9 commits into from
Jul 18, 2020
Merged

Standalone coverage #1079

jgebal merged 9 commits into from
Jul 18, 2020

Conversation

@jgebal
Copy link
Member

@jgebal jgebal commented Jun 13, 2020 •
edited
Loading

Resolves #1025

Coverage can now be gathered outside of utPLSQL test run (without invoking ut.run)

Example:

begin 
    ut_runner.coverage_start('A6AA5B7361251CE6E053020011ACA078');
    some_schema.some_package.procedure; 
    ut_runner.coverage_stop();
end;
/

In same session or even a separate session (once previous call was finished) run:

    select *
      from
        table (
          ut_coverage_cobertura_reporter( ).get_report(
            ut_coverage_options(
              coverage_run_id => 'A6AA5B7361251CE6E053020011ACA078',
              include_objects => ut_varchar2_rows('SOME_PACKAGE'),
              schema_names => ut_varchar2_rows('SOME_SCHEMA')
              )
            )
          );

TODO

  • Documentation
  • Internal code cleanup and refactoring
  • Test fixes

@ksawerykarwacki - feel free to give a try to the version from this feature branch.
Let me know if you encounter any issues or have any questions.

jgebal added 5 commits June 11, 2020 00:23
@jgebal
Reworked coverage to allow for gathering coverage without calling utP…
93fd222 
…LSQL.

Enables multi-session coverage too.
@jgebal
Removed mocking API for coverage,
641d87c 
Fixed failing tests for 11.2 and 12.1
Refactored some parts of tests
@jgebal
Workaround for 12.2 issue with conditional compilation in package spec.
52e1db9 
Added missing testcase for get_report_cursor
@jgebal
cleanup of unneeded safety code
a17c3af
@jgebal
Refactoring tests
09ab226
@jgebal jgebal mentioned this pull request Jun 21, 2020
Closed
@jgebal
Copy link
Member Author

jgebal commented Jun 21, 2020 •
edited
Loading

  • client_character_set needs to be added to get_report and get_report_cursor.
    Currently it is missing.

@jgebal jgebal added this to the 3.1.11 milestone Jun 21, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

82.3% 82.3% Coverage
0.9% 0.9% Duplication

@jgebal
Copy link
Member Author

jgebal commented Jun 28, 2020

@pesse , @PhilippSalvisberg, @lwasylow
Any comments on the way the new API is built?

Can one of you review the documentation and provide some feedback before I merge?

I think it's a major addition to current API and would like to know that I got it right.

Also, it would be great to know that the documentation is sufficient.

@jgebal
Copy link
Member Author

jgebal commented Jul 18, 2020

Merging as there are no review comments in 20 days.

@jgebal jgebal merged commit ad39737 into develop Jul 18, 2020
@jgebal jgebal deleted the feature/standalone_coverage branch July 18, 2020 16:52
@PhilippSalvisberg PhilippSalvisberg mentioned this pull request Feb 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lwasylow lwasylow Awaiting requested review from lwasylow

@pesse pesse Awaiting requested review from pesse

@PhilippSalvisberg PhilippSalvisberg Awaiting requested review from PhilippSalvisberg

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

v3.1.11

Development

Successfully merging this pull request may close these issues.

Use coverage without ut.run()

2 participants

@jgebal