Skip to content

Add multi file support to Json/Toml/csv resource#899

Merged
olblak merged 13 commits into
updatecli:mainfrom
olblak:multiJsonFile
Oct 4, 2022
Merged

Add multi file support to Json/Toml/csv resource#899
olblak merged 13 commits into
updatecli:mainfrom
olblak:multiJsonFile

Conversation

@olblak

@olblak olblak commented Sep 30, 2022

Copy link
Copy Markdown
Member
  • Add multi file support to Json/Toml/Csv resource
  • Refactor Json resource to create an intermediate package named Dasel which could be reused for the csv and toml resource
    • github.com/updatecli/updatecli/pkg/plugins/utils/dasel"

Test

To test this pull request, you can run the following commands:

cp <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak added enhancement New feature or request resource-json labels Sep 30, 2022
@olblak olblak marked this pull request as draft September 30, 2022 19:30
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Refactor toml to use dasel package

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak changed the title Add multi file support to Json resource Add multi file support to Json/Toml resource Sep 30, 2022
olblak added 4 commits October 3, 2022 09:24
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Refactor csv resource to use custom dasel package

Signed-off-by: Olblak <me@olblak.com>
@olblak olblak marked this pull request as ready for review October 3, 2022 07:35
@olblak olblak changed the title Add multi file support to Json/Toml resource Add multi file support to Json/Toml/csv resource Oct 3, 2022
olblak added 3 commits October 3, 2022 20:27
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak merged commit 7f70e4c into updatecli:main Oct 4, 2022
@olblak olblak deleted the multiJsonFile branch June 12, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant