Deprecate depends_on in favor of dependson#886
Merged
Conversation
Signed-off-by: Olblak <me@olblak.com>
lemeurherve
reviewed
Sep 23, 2022
lemeurherve
left a comment
Member
There was a problem hiding this comment.
Can the depends_on deprecation be handled in a single place instead of being duplicated 3 times?
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
Signed-off-by: Olblak <me@olblak.com>
Member
Author
Well we could refactor the code to do so but I don't think it's worth doing now. |
Signed-off-by: Olblak <me@olblak.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olblak me@olblak.com
Align depends_on syntax with the current manifest convention.
This also remove the confusion introduce by jsonschema
Test
To test this pull request, you can run the following commands:
Additional Information
Tradeoff
Potential improvement