fix: truncate pull request body#882
Merged
olblak merged 3 commits intoSep 23, 2022
Merged
Conversation
hervelemeur
reviewed
Sep 22, 2022
Member
|
Ho nice, it's great the way you handle it as we'll be able to use this truncate for gitea pullrequest and other scm coming |
olblak
approved these changes
Sep 23, 2022
olblak
left a comment
Member
There was a problem hiding this comment.
I already approve as the current the PR solve the initial. We have small nitpick suggestion.
I'll wait for the test to finish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #873
Truncate long PR message to avoid
body is too longerror.Test
To test this pull request, you can run the following commands:
go test -timeout 30s -run ^TestString$ github.com/updatecli/updatecli/pkg/plugins/utils/truncateAdditional Information
Tradeoff
No response
Potential improvement
No response