Skip to content

No default crawler when autodiscovery is used with manifest#877

Merged
olblak merged 5 commits into
updatecli:mainfrom
olblak:defaultAutodiscovery
Sep 22, 2022
Merged

No default crawler when autodiscovery is used with manifest#877
olblak merged 5 commits into
updatecli:mainfrom
olblak:defaultAutodiscovery

Conversation

@olblak

@olblak olblak commented Sep 19, 2022

Copy link
Copy Markdown
Member

As introduced on #874

I find it very annoying that I have to disable all crawler if I want an autodiscovery manifest handle only one crawler
No default crawler when autodiscovery is used from manifest

Signed-off-by: Olblak me@olblak.com

Test

To test this pull request, you can test the two following workflow:

go build -o bin/updatecli .
./bin/updatecli manifest show --config e2e/updatecli.d/warning.d/autodiscovery/fleet --experimental 
# Should only detect rancherl/fleet and helm manifest 
./bin/updatecli manifest show --local-autodiscovery --experimental
# Should display rancher/fleet, helm, and Maven manifest
go test

Additional Information

Tradeoff

Potential improvement

@olblak olblak added the autodiscovery All things related to the autodiscovery feature label Sep 19, 2022
@olblak olblak changed the title No default crawler when autodiscovery is used from manifest No default crawler when autodiscovery is used with manifest Sep 19, 2022
@olblak olblak marked this pull request as draft September 20, 2022 13:22
Signed-off-by: Olblak <me@olblak.com>
Signed-off-by: Olblak <me@olblak.com>
@olblak olblak marked this pull request as ready for review September 20, 2022 16:19
@olblak olblak merged commit f16b327 into updatecli:main Sep 22, 2022
@olblak olblak added the enhancement New feature or request label Sep 24, 2022
@olblak olblak deleted the defaultAutodiscovery branch June 12, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autodiscovery All things related to the autodiscovery feature enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant