feat(autodiscovery/argocd): enhance support of ApplicationSet with multiple sources#8677
Merged
Conversation
…sts with multiple sources
olblak
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The ArgoCD autodiscovery plugin currently supports multiple sources only for
Applicationresources,not for
ApplicationSet. When the autodiscovery runs in a folder containing ApplicationSets withmultiple sources, it fails to detect them:
Enhancement
Add support for
ApplicationSetresources with multiple sources (spec.template.spec.sources[]).Before
spec.source✅spec.sources[]✅spec.template.spec.source✅spec.template.spec.sources[]➡️ Not supportedAfter
spec.source✅spec.sources[]✅spec.template.spec.source✅spec.template.spec.sources[]✅Test
To test this pull request, you can run the following commands: