fix(cache): include SCM identity in source cache key#8523
Merged
olblak merged 1 commit intoApr 20, 2026
Conversation
Two pipelines reusing the same SCMID label (e.g. scmid: source) against different repositories collide in the source cache when their Kind+Spec match, serving the first pipeline's content to the second. Fold the resolved SCM URL and source branch into the cache key. Nil-SCM callers keep the pre-fix hash via json:"scm,omitempty". Credentials live in separate Config fields and are not part of the identity. Fixes: updatecli#8522
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8522
Two pipelines reusing the same SCMID label (e.g. scmid: source) against different repositories collide in the source cache when their Kind+Spec match, serving the first pipeline's content to the second.
Fold the resolved SCM URL and source branch into the cache key. Nil-SCM callers keep the pre-fix hash via json:"scm,omitempty". Credentials live in separate Config fields and are not part of the identity.
Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
Potential improvement