fix(yaml): compare decoded scalar values to avoid rewriting folded blocks#8296
Merged
olblak merged 2 commits intoApr 8, 2026
Merged
Conversation
…ocks Folded/literal scalars (>-, |) stringify with their formatting markers, causing the change-detection to always report a diff and rewrite the node, which corrupted the original formatting on every run. Fixes updatecli#8295 Signed-off-by: Loïs Postula <lois@postu.la>
olblak
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8295
Folded/literal scalars (>-, |) stringify with their formatting markers, causing the change-detection to always report a diff and rewrite the node, which corrupted the original formatting on every run.
Test
To test this pull request, you can run the following commands:
Two regression tests added in target_test.go:
>-folded block with identical value: asserts no rewrite.>-folded block with changed value: asserts rewrite still triggers.Additional Information
Checklist
Tradeoff
Potential improvement