Skip to content

Dummy PR#2758

Closed
lemeurherveCB wants to merge 6 commits into
updatecli:mainfrom
lemeurherveCB:patch-1
Closed

Dummy PR#2758
lemeurherveCB wants to merge 6 commits into
updatecli:mainfrom
lemeurherveCB:patch-1

Conversation

@lemeurherveCB

Copy link
Copy Markdown
Contributor

Trying to reproduce the atest strange linter error cf https://matrix.to/#/!TQpOBNqKouILtnYnAd:gitter.im/$c9R6t681xgJxxLJk1UQ3aBBI4RPrwyUc0WMyagQdpao?via=gitter.im&via=matrix.org&via=matrix.freyachat.eu

Fix #XXX

Test

To test this pull request, you can run the following commands:

cd <to_package_directory>
go test

Additional Information

Tradeoff

Potential improvement

Comment thread README.adoc Outdated
Comment thread README.adoc Outdated
Comment thread README.adoc Outdated
Comment thread README.adoc Outdated
Comment thread README.adoc Outdated
@jsoref

jsoref commented Oct 10, 2024

Copy link
Copy Markdown
Contributor

It's coming from:

(?:^|[\t ,>"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,})

You'll want to adjust that pattern (the simplest thing is to remove the l)

-(?:^|[\t ,>"'`=(])-[DPWXYLlf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) 
+(?:^|[\t ,>"'`=(])-[DPWXYLf](?=[A-Z]{2,}|[A-Z][a-z]|[a-z]{2,}) 

It's possible for check-spelling to identify which patterns produced a fractional term, but it's somewhat expensive (it'd involve running all the patterns against the line until it identifies just the ones that contribute).

I'm not sure if @prerelease would improve this case (I'm currently cleaning up all of the commits I have in prerelease... hoping to have a clean test to release really soon).

@lemeurherveCB

Copy link
Copy Markdown
Contributor Author

Opened #2804, thanks again @jsoref!

@lemeurherveCB lemeurherveCB deleted the patch-1 branch October 10, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants