feat(docker): add update actions to container context menu#1867
Conversation
Add "Check for updates" and "Update" options to the right-click context menu for individual Docker containers. Previously, users could only access these actions via the bulk actions toolbar. - Add "Check for updates" action that triggers digest refresh for a single container - Always show "Update" option - enabled when update available, disabled with "Up to date" label otherwise - Update actions are now in their own menu group for better organization Addresses task: https://app.asana.com/0/0/1212596388177290 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. WalkthroughAdded per-row update-check support for Docker container rows by introducing a Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Table as DockerContainersTable.vue
participant RowActions as useDockerRowActions
participant UpdateHandler as useDockerUpdateActions
participant API as Backend API
User->>Table: Click "Check for updates" on row
Table->>RowActions: invoke onCheckForUpdates(row)
RowActions->>UpdateHandler: call handleCheckForUpdates([row])
UpdateHandler->>API: trigger refresh digests mutation
API-->>UpdateHandler: mutation result
UpdateHandler-->>RowActions: update checking state
RowActions-->>Table: reflect updated checkingForUpdates state
Table-->>User: UI shows check progress/result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2a85622cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| onViewLogs: handleViewLogs, | ||
| onOpenConsole: handleOpenConsole, | ||
| onManageSettings: handleManageSettings, | ||
| onCheckForUpdates: (row) => void handleCheckForUpdates([row]), |
There was a problem hiding this comment.
Avoid per-row “Check for updates” implying a scoped refresh
The new row action wires onCheckForUpdates to handleCheckForUpdates([row]), but that handler (in useDockerUpdateActions) always calls the global REFRESH_DOCKER_DIGESTS mutation with no container IDs and then refetches all containers. That means right‑clicking a single container will refresh every container while the toast and busy state suggest only that one was checked. This is a functional mismatch introduced by the new row action; either update the action/label to reflect a global refresh or pass a container ID if the backend supports a scoped refresh.
Useful? React with 👍 / 👎.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1867 +/- ##
==========================================
- Coverage 46.49% 46.47% -0.02%
==========================================
Files 954 954
Lines 59788 59810 +22
Branches 5552 5552
==========================================
Hits 27799 27799
- Misses 31870 31892 +22
Partials 119 119 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Though I haven't tested "Right-click a container with update available → verify "Update" option is enabled and functional", I'm merging because the code seems benign, and this feature is in testing, not prod. |
|
This plugin has been deployed to Cloudflare R2 and is available for testing. |
Summary
Previously, users could only check for updates or trigger updates via the bulk actions toolbar. Now these actions are available directly in the context menu when right-clicking a container.
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.