Skip to content

AST Reference Resolution Improvements && AST Yul FunctionCall Nil Fix#128

Merged
0x19 merged 1 commit intomainfrom
ast/reference-fix
Oct 18, 2023
Merged

AST Reference Resolution Improvements && AST Yul FunctionCall Nil Fix#128
0x19 merged 1 commit intomainfrom
ast/reference-fix

Conversation

@0x19
Copy link
Contributor

@0x19 0x19 commented Oct 18, 2023

Basically few issues resolved with this fix:

  • UpdateReferenceById() in AST did not take under consideration GlobalNodes. It's sorted now.
  • AST Yul GetNode() did not have all YulIdentifiers applied.
  • AST YulFunctionCall did not take under consideration YulIdentifier resulting in GetNodes() having a nil item, resulting in panics across the board.

@0x19 0x19 added bug Something isn't working ast Abstract Syntax Tree labels Oct 18, 2023
@0x19 0x19 self-assigned this Oct 18, 2023
@0x19 0x19 merged commit 744d0cd into main Oct 18, 2023
@0x19 0x19 deleted the ast/reference-fix branch October 18, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ast Abstract Syntax Tree bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments