feat(redis): add clientInfoTag support with version detection#736
Open
feat(redis): add clientInfoTag support with version detection#736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #735
Description
Adds
clientInfoTagsupport to the Redis driver to leverage Redis'sCLIENT SETINFOcommand.This feature helps Redis administrators identify which higher-level library is using ioredis by setting a custom tag in the
CLIENT SETINFO LIB-NAMEcommand.Changes
clientInfoTagoption toRedisOptionsinterfaceunstorage_vX.X.Xusing package.json versionclientInfoTagoverrideclusterOptions.redisOptionsclientInfoTagbehaviorExample Usage
Testing
All existing tests pass (19/19)
Added 2 new tests for clientInfoTag functionality
Build successful
Linter passes
Type checking passes
References
Redis CLIENT SETINFO documentation: https://redis.io/docs/latest/commands/client-setinfo/
ioredis clientInfoTag option: https://github.com/redis/ioredis#client-setinfo