Merged
Conversation
Collaborator
|
Yeah I think we can remove the content editable on all elements, tested on my machine and it works fine The reason for that to be there is that the old code needs it to determine caret position when trying to insert the caret at the correct location, but the new code doesn't need it anymore so we can safely remove it. |
Contributor
Author
|
Got it! Removed and it doesn't create new bugs on my machine. |
1c3de4c to
fb8cbca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable
contenteditablefor the<code>element allows the code block (<pre><code></code></pre>, created by ```) to be focused with a single click.I wonder if we can disable
contenteditablefor all elements, since we don't need them to be editable in the viewing mode. But also I'd love to know, does it exist for some reasons?