Looks like images causes the editor to overflow - is there a good way to handle it in the editor? (assuming that we can't control the content renderer, in this case, the markdown view)

Also I noticed that the daily notes page has too narrow borders, since the card already applies the margin, so I made them the same width in my commit here. Don't know how do you like your code hygiene, lemme know if you don't want me to do that :)

Otherwise it looks pretty cool! <3

Looks like images causes the editor to overflow - is there a good way to handle it in the editor? (assuming that we can't control the content renderer, in this case, the markdown view)

The editor already applies width: 100% to many children elements to constraint their sizes. I found the problem to be that in the Markdown renderer, img didn't have any constraints on width, so it naturally overflows.

I think it makes sense to fix it in the Markdown renderer, since we don't want image to overflow in any cases.

Also I noticed that the daily notes page has too narrow borders, since the card already applies the margin

From my perspective the borders look fine, but seeing your changes I guess you think the padding is too large?

I didn't notice that daily note also uses the same component, and I think your changes are reasonable, so let's keep it.

Btw, I see you merge main into this branch to keep it up to date. I recommend using git rebase main instead, to replay all commits in this branch on top of main, so not only there won't be an extra merge commit, but also the commit history will be easier to read (all commits above the latest commit of main are new). One bummer may be that once you rebase a branch you need to force-push it, but in fact it's commonly acceptable to force-push feature branches, just don't force-push main.

I recommend using git rebase main instead

I feel like it's more intuitive to use merge commits since it's right inside the GitHub GUI and natural in the flow of reviewing -> merging, instead of having to go to a CLI. What do you think @TheExGenesis ?

NVM I saw the option in the GUI

At the same time I think rebasing it diverges your local version too, so maybe you should only do it yourself? Unless me or Francisco thought it's ready to be merged right after rebasing it

@thesophiaxu Yeah, rebasing diverges the branch that is being rebased, for example, after running git rebase main on a feature branch locally, it needs to be force-pushed. But, using "Rebase and merge" button in the Github GUI to merge a PR will not diverge the main branch, since the rebasing is done on the feature branch. See Rebasing and merging your commits for details.