Skip to content

ICU-23481 MF2: get standard functions and allow chaining - #4118

Draft
mihnita wants to merge 2 commits into
unicode-org:mainfrom
mihnita:mihai_function_chaining
Draft

ICU-23481 MF2: get standard functions and allow chaining#4118
mihnita wants to merge 2 commits into
unicode-org:mainfrom
mihnita:mihai_function_chaining

Conversation

@mihnita

@mihnita mihnita commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The proposed API is minimal, one extra method in MFFunctionRegistry:

public class MFFunctionRegistry {
   ...
   public static MFFunctionRegistry getStandardFunctionsRegistry() { ... }
}

The most interesting part of the PR is the StandardFunctionsChainingTest, showing off what can be done with it.

Checklist

  • Required: Issue filed: ICU-23481
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

@mihnita
mihnita requested a review from srl295 August 14, 2026 22:09
@mihnita
mihnita force-pushed the mihai_function_chaining branch from 80ee89c to 55bb2b3 Compare August 14, 2026 22:20
@jira-pull-request-webhook

Copy link
Copy Markdown

Notice: the branch changed across the force-push!

  • icu4j/main/core/src/main/java/com/ibm/icu/message2/MFFunctionRegistry.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@mihnita
mihnita requested a review from catamorphism August 14, 2026 22:23
@mihnita

mihnita commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Note: I don't intend to submit this, at least no right now.
It is just a proof of concept for the proposed API.

Note 2: I was unable to add moconor as reviewer.
Steven, if you can add him it would be nice, thank you!

I will soon update the design document with the proposed API.

...

Never mind, that exact API is already proposed in the design document.

@srl295

srl295 commented Aug 14, 2026

Copy link
Copy Markdown
Member

@mihnita yes, i'll take a look and also work on the C++ side

@markusicu
markusicu marked this pull request as draft August 20, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants