ICU-23481 MF2: get standard functions and allow chaining - #4118
Draft
mihnita wants to merge 2 commits into
Draft
Conversation
mihnita
force-pushed
the
mihai_function_chaining
branch
from
August 14, 2026 22:20
80ee89c to
55bb2b3
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Contributor
Author
|
Note: I don't intend to submit this, at least no right now. Note 2: I was unable to add moconor as reviewer. I will soon update the design document with the proposed API. ... Never mind, that exact API is already proposed in the design document. |
Member
|
@mihnita yes, i'll take a look and also work on the C++ side |
markusicu
marked this pull request as draft
August 20, 2026 17:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proposed API is minimal, one extra method in
MFFunctionRegistry:The most interesting part of the PR is the
StandardFunctionsChainingTest, showing off what can be done with it.Checklist