Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: webflow/webflow-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: umpa-loomp/webflow-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Oct 8, 2025

  1. fix(sites): Correct response parsing for sites.list() 

    The `sites.list()` method incorrectly parses the API response, leading to a `ValidationError`.

The `/v2/sites` endpoint returns a JSON object with a `sites` key containing a list of site objects: `{ "sites": [...] }`.

The current implementation attempts to parse this top-level object as a single `Site` model, which fails because required fields like `id` are missing at that level.

This commit corrects the behavior by:
1. Updating the return type hint to `List[Site]`.
2. Modifying the parsing logic to first extract the list from the `sites` key before passing it to `pydantic.parse_obj_as`.

This ensures the method correctly returns a list of `Site` objects as expected.
    @umpa-loomp
    umpa-loomp authored Oct 8, 2025
    Configuration menu
    Copy the full SHA
    f79b551 View commit details
    Browse the repository at this point in the history
Loading