onCreateNode mouse position#98
Conversation
|
I would recommend documenting a change and bumping the major version on this. Please document the change in the README and add the previous implementation to the deprecated section. We will release a major version update for this. Generally speaking, a major version would not normally be necessary, however we have a large customer that seems to have added a final parameter to their onCreateNode function, overloading it to perform some other tasks. If we don't do a major version change then they'll get the update and the extra tasks will always be performed (object shallow-equals true). |
|
I think a better approach would be to pass back the mouse event. I believe the old v4 code passed back both the mouse event as well as the d3 object. Another alternative within onCreateNode is to use |
|
@ajbogh I'll add the readme for sure. |
…react-digraph into oncCreateNode-mouse-position
|
@ajbogh I just documented the changes in Readme and replaced |
|
@ajbogh Please, Please consider merging this. 🙏🙏🙏🙏🙏🙏🙏🙏🙏🙏 |
|
Sorry for the delay. I needed to talk with one of our primary users to determine a proper version number for this. They happened to overload the createNode callback function with other parameters, so we will need to create a major version bump instead of a minor change so that they don't accidentally install the change and break themselves. |
|
This is published as 6.0.0. Thanks! |
before:
after:
User can interact with the actual mouse position with this option.