Moved all geometry classes defined on the fly in Vizard to AnalyzerVisitors/GeometricInfo#358
Merged
alkemyst merged 7 commits intotkLayout:dev_gabiefrom Apr 5, 2017
Merged
Conversation
…Visitors + moved Vizard static to VizardTools.hh
alkemyst
reviewed
Apr 5, 2017
| #include <global_constants.hh> | ||
| #include "VizardTools.hh" | ||
| #include <Tracker.hh> | ||
| #include <Analyzer.hh> |
Contributor
There was a problem hiding this comment.
If the purpose is making Analyzer disappear, shouldn't we move the constants/variables/functions we need in Analyzer.hh into something different? I created AnalyzerTools for this, but any other choice is equally fine for me
Contributor
There was a problem hiding this comment.
More in general: do we need Analyzer.hh here at all?
Contributor
Author
There was a problem hiding this comment.
Ok yes I have replaced #include <Analyzer.hh> by #include <SimParms.hh> #include <TagMaker.hh>
Contributor
|
Was this PR tested? |
Contributor
Author
|
Yes, same output ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in the process of making Vizard disappear (to be continued ..).