Skip to content

Add Japanese translation for index.md #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tiangolo merged 12 commits into from
Aug 29, 2020
Merged

Add Japanese translation for index.md #1571

tiangolo merged 12 commits into from
Aug 29, 2020
+513 −0

Conversation

@ryuckel
Copy link
Contributor

@ryuckel ryuckel commented Jun 14, 2020

As I mentioned the issue #1503 ,I translated index.md to Japanese.

@codecov
Copy link

codecov bot commented Jun 14, 2020 •
edited
Loading

Codecov Report

Merging #1571 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1571   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0916c1c...00eb9a0. Read the comment docs.

@tiangolo tiangolo added lang-all Translations lang-ja Japanese translations labels Jun 14, 2020
tokusumi
tokusumi suggested changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo and improve translation

@ryuckel
Copy link
Contributor Author

ryuckel commented Jun 25, 2020

@tokusumi
Thank you so much!
I took in your suggestion!

@tokusumi tokusumi mentioned this pull request Jun 25, 2020
Merged
This was referenced Jun 30, 2020
Merged
Merged
Merged
Merged
This was referenced Jul 7, 2020
Merged
Merged
SwftAlpc
SwftAlpc suggested changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@SwftAlpc SwftAlpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest some translation corrections.

This was referenced Aug 15, 2020
Merged
Merged
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2020

📝 Docs preview for commit 8451815 at: https://5f3922fbad43c480daa78f4c--fastapi.netlify.app

SwftAlpc
SwftAlpc approved these changes Aug 16, 2020
View reviewed changes
Copy link
Contributor

@SwftAlpc SwftAlpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SwftAlpc
Copy link
Contributor

SwftAlpc commented Aug 16, 2020

@tiangolo
Hello.
Thank you for developing the best framework possible.
Currently, the Japanese version of index.md has been approved by two people.
Are there any requirements to be merged?
Are there not enough reviewers as it is now?
Thank you.

This was referenced Aug 19, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
@tokusumi tokusumi mentioned this pull request Aug 22, 2020
Closed
This was referenced Aug 23, 2020
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2020

📝 Docs preview for commit 00eb9a0 at: https://5f4a53fd15bbe44a2c9c8aff--fastapi.netlify.app

@tiangolo tiangolo merged commit e1e8627 into fastapi:master Aug 29, 2020
@tiangolo
Copy link
Member

tiangolo commented Aug 29, 2020

This is awesome! Thanks @ryuckel ! 🚀 🎉

And thanks @tokusumi and @SwftAlpc for the reviews! 🙇 ☕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@tokusumi tokusumi tokusumi approved these changes

@SwftAlpc SwftAlpc SwftAlpc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting-review lang-all Translations lang-ja Japanese translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ryuckel @SwftAlpc @tiangolo @tokusumi