Skip to content

fix: dispose shared fixtures when only a subset of consuming tests runs #6156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 3 commits into from
Jun 3, 2026
Merged

fix: dispose shared fixtures when only a subset of consuming tests runs #6156

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa338fe
fix: dispose shared fixtures when only a subset of consuming tests runs
thomhurst Jun 3, 2026
1d0b0a3
refactor: remove dead ClearStaticTracking superseded by DisposeAndCle…
thomhurst Jun 3, 2026
d4d6cdf
fix: route static property disposal through ObjectTracker to prevent …
thomhurst Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: remove dead ClearStaticTracking superseded by DisposeAndCle… 
…arStaticTrackingAsync
  • Loading branch information
@thomhurst
thomhurst committed Jun 3, 2026
commit 1d0b0a363e196681401977be7b67fab22a99226e
12 changes: 2 additions & 10 deletions TUnit.Core/Tracking/ObjectTracker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ namespace TUnit.Core.Tracking;
/// </summary>
/// <remarks>
/// The static <c>s_trackedObjects</c> dictionary is shared across all tests.
/// Call <see cref="ClearStaticTracking"/> at the end of a test session to release memory.
/// Call <see cref="DisposeAndClearStaticTrackingAsync"/> at the end of a run session to
/// dispose any leftovers and release memory.
/// </remarks>
internal class ObjectTracker(TrackableObjectGraphProvider trackableObjectGraphProvider, Disposer disposer)
{
Expand All @@ -27,15 +28,6 @@ internal class ObjectTracker(TrackableObjectGraphProvider trackableObjectGraphPr
/// </summary>
public static IReadOnlyCollection<Exception> GetAsyncCallbackErrors() => s_asyncCallbackErrors.ToArray();

/// <summary>
/// Clears all static tracking state. Call at the end of a test session to release memory.
/// </summary>
public static void ClearStaticTracking()
{
s_trackedObjects.Clear();
s_asyncCallbackErrors.Clear();
}

/// <summary>
/// Disposes any objects still tracked with a positive reference count, then clears all
/// static tracking state. Call at the end of a run session: every executed test has
Expand Down
Loading