adding kafka test container support#127
adding kafka test container support#127tillahoffmann merged 3 commits intotestcontainers:masterfrom ash1425:kafka-support
Conversation
|
I tried these failing tests locally, They work in all python versions (used venv) but were flaky and I had to try multiple time. |
|
@tillahoffmann Can you please review this change? |
tillahoffmann
left a comment
There was a problem hiding this comment.
Thank you for the addition! Some comments inline.
|
@tillahoffmann Thanks for the review comments. I have accommodated those in latest commit. |
|
This is going to ensure that we will have one and only one message in the consumer in integration test. |
I understand. Then it looks like the |
…d to provide correct feedback
|
@ash1425 Hey Ashay, do you have bandwidth working on the PR? If not, maybe I can help to cross the finish line? |
|
@YikSanChan For now, I have incorporated all the review comments and merged upstream changes to resolve the conflicts. I think we should be good to approve and merge if all tests pass. |
|
@ash1425 Great thanks! If there is any more comment from testcontainers members, I can try to resolve |
|
@tillahoffmann Could you please taking a look? This is the feature I am looking for. Thank you! |
|
@tillahoffmann CI seems happy. Are we good to get these changes in? |
fix #121 This PR adds support for kafka container. Heavily inspired from java testcontainer's Kafka module.