Skip to content

fix(restic): suggest tzdata for correct timezone display#30682

Open
ykrishhh wants to merge 1 commit into
termux:masterfrom
ykrishhh:fix/restic-timezone
Open

fix(restic): suggest tzdata for correct timezone display#30682
ykrishhh wants to merge 1 commit into
termux:masterfrom
ykrishhh:fix/restic-timezone

Conversation

@ykrishhh

Copy link
Copy Markdown

Closes #30657

Adds tzdata to restic suggested dependencies so users can install it for correct timezone display in snapshot listings.

Go time.LoadLocation() needs /usr/share/zoneinfo/ to resolve TZ.
Without tzdata, restic snapshots shows UTC.

Closes termux#30657
Comment thread packages/restic/build.sh
TERMUX_PKG_DESCRIPTION="Fast, secure, efficient backup program"
TERMUX_PKG_LICENSE="BSD"
TERMUX_PKG_MAINTAINER="@termux"
TERMUX_PKG_VERSION="0.19.1"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will need TERMUX_PKG_REVISION=1 added right below this.

@robertkirkman

Copy link
Copy Markdown
Member

does it actually fix the issue completely just by being installed with no user configuration additionally required?

If so, then it should be in TERMUX_PKG_DEPENDS or TERMUX_PKG_RECOMMENDS, not TERMUX_PKG_SUGGESTS, in order to fix it automatically for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: restic snapshots command ignores system timezone

2 participants