Skip to content

Cherrypicks 1.8rc1 fix tf.GIT_VERSION always 'unknown' on windows cmake build (#16730) - #18679

Merged
martinwicke merged 2 commits into
tensorflow:r1.8from
yifeif:cherrypicks_Z6PNR
Apr 19, 2018
Merged

Cherrypicks 1.8rc1 fix tf.GIT_VERSION always 'unknown' on windows cmake build (#16730)#18679
martinwicke merged 2 commits into
tensorflow:r1.8from
yifeif:cherrypicks_Z6PNR

Conversation

@yifeif

@yifeif yifeif commented Apr 19, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@yifeif
yifeif requested a review from case540 April 19, 2018 00:13
@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot googlebot removed the cla: no label Apr 19, 2018
@yifeif

yifeif commented Apr 19, 2018

Copy link
Copy Markdown
Contributor Author

clabot this is a cherrypick from #16730

@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@yifeif yifeif added cla: yes and removed cla: no labels Apr 19, 2018
@googlebot

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@martinwicke
martinwicke merged commit cf9afc9 into tensorflow:r1.8 Apr 19, 2018
@martinwicke

Copy link
Copy Markdown
Member

Oops, I merged this. @yifeif I hope I didn't mess up the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants