Get rid of the buffer_assignments member field in gpu_executable. - #122272
Merged
Conversation
copybara-service
Bot
force-pushed
the
exported_pr_939756005
branch
6 times, most recently
from
July 6, 2026 12:10
e5a5d73 to
8a486ee
Compare
copybara-service
Bot
force-pushed
the
exported_pr_939756005
branch
2 times, most recently
from
July 7, 2026 07:47
409cd3e to
5a46c8d
Compare
Before a GpuExecutable could have either: 1. the `buffer_assignment_` field populated, or; 2. the `buffer_allocations_` **and** `buffer_assignment_proto_` populated. Now its always **2.**, i.e. now we always pass the buffer allocations that we extracted from the buffer assigments. PiperOrigin-RevId: 943734029
copybara-service
Bot
force-pushed
the
exported_pr_939756005
branch
from
July 7, 2026 08:21
5a46c8d to
15dfd9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get rid of the buffer_assignments member field in gpu_executable.
Before a GpuExecutable could have either:
buffer_assignment_field populated, or;buffer_allocations_andbuffer_assignment_proto_populated.Now its always 2., i.e. now we always pass the buffer allocations that we extracted from the buffer assigments.