refactor(cli): validate cli arguments with clap - #1235
Conversation
b07b900 to
617427c
Compare
617427c to
86d103e
Compare
clap
|
cyclops audit super-fast |
|
cc @0xKitsune Cyclops audit event published. View workflow run Config: config: |
tempoxyz-bot
left a comment
There was a problem hiding this comment.
👁️ Cyclops Review
This change correctly moves L1 WebSocket URL validation into Clap parsing, but deleting the adjacent portal-address validation exposes a test/dev sentinel through production CLI configuration.
Reviewer Callouts
- ⚡ Deprecated
--zone.idremoval: Existing deployment manifests or CI that still pass this flag will fail argument parsing; confirm all consumers have migrated. - ⚡ Zero-address sentinel: Consider replacing
Address::ZEROas the test/dev mode marker with a distinct configuration type.
|
+1 |
There was a problem hiding this comment.
Approving on behalf of @0xalpharush, who approved this pull request with a +1 comment via Voight-Kampff (head acfa726e09f5).
GitHub branch protection considers pull request reviews, not +1 comments. Voight-Kampff is recording this approval on the reviewer's behalf so branch protection requirements are met.
This PR moves node CLI validation into Clap parsers and removes the deprecated zone ID argument.