feat(sequencer): add persistent batch submission actor - #1194
Open
adityapk00 wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
cyclops audit fast |
|
cc @adityapk00 Cyclops audit event published. View workflow run Config: config: |
tempoxyz-bot
left a comment
There was a problem hiding this comment.
👁️ Cyclops Review
PR #1194 adds and exports a staged, role-aware BatchSubmissionActor for zone-to-L1 settlement. Head drift was detected from the audited commit, so the findings were rechecked against the current PR head and still apply to the current diff. The remaining issues are Medium-severity liveness/handoff defects that should be fixed before wiring this actor into production.
Reviewer Callouts
- ⚡ Staged actor handoff: The new actor is exported but not yet production-wired; treat these as pre-integration blockers before replacing the supervised
ZoneMonitorpath. - ⚡ Certificate wait/error hardening:
wait_for_certificatedirectly awaitsportal_block_hashduring polling, so hung or failing L1 RPCs can still bypass the actor's unsent-operation handling; review this while redesigning retry/resync behavior. - ⚡ Future caller contracts: Candidates are dropped while a boundary is active, and concurrent
set_rolecallers can wait forever if another role supersedes their requested role. The future producer and role controller should have explicit serialization/backpressure semantics.
adityapk00
force-pushed
the
aditya/persistent-batch-submission-actor
branch
from
August 17, 2026 12:39
adf240b to
1ecba99
Compare
adityapk00
marked this pull request as ready for review
August 17, 2026 18:52
adityapk00
force-pushed
the
aditya/persistent-batch-submission-actor
branch
from
August 18, 2026 12:32
1ecba99 to
477dc47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the persistent batch-submission actor and focused concurrency coverage.
Stacked on #1 of this series.