Skip to content

feat: add schedulerName, runtimeClassName and priorityClassName to pod specs - #949

Merged
robholland merged 1 commit into
temporalio:mainfrom
somaz94:feat/pod-scheduling-runtime-fields
Jul 27, 2026
Merged

robholland merged 1 commit into
temporalio:mainfrom
somaz94:feat/pod-scheduling-runtime-fields

Conversation

@somaz94

@somaz94 somaz94 commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

This adds three optional, opt-in pod fields (schedulerName, runtimeClassName, priorityClassName) to the server, web and admintools workloads, mirroring the nodeSelector/affinity/tolerations/topologySpreadConstraints knobs already present on these pods.

  • server: server-wide value with per-service override, using the same default $.Values.server.<field> $serviceValues.<field> pattern as nodeSelector/affinity/tolerations
  • web and admintools: .Values.<component>.<field>

All three default to "", so the rendered output is byte-identical for existing users (no behavior change).

CONTRIBUTING lists "scheduling constraints required by platform policies" as an accepted change. These fields are commonly needed for sandboxed/GPU runtimes (runtimeClassName), custom schedulers, and priority-based preemption.

Validation (run locally):

  • helm unittest . -> 152 passed. Added coverage in server_deployment_test.yaml and admintools_deployment_test.yaml, plus a new web_deployment_test.yaml (default renders nothing, set values render, server per-service overrides the server-wide default).
  • ct lint --check-version-increment=false -> all charts linted successfully across the mysql / postgres-es / postgres ci value files.
  • helm template default render diff vs main is empty (byte-identical); with the fields set they render on every enabled workload.

I did not run the kind ct install scenario since the ci/*-values.yaml files do not set these fields and the default render is unchanged, so it would exercise nothing new. Happy to add a ci scenario if you prefer.

@CLAassistant

CLAassistant commented Jul 9, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

somaz94 added a commit to somaz94/somaz94 that referenced this pull request Jul 9, 2026
@somaz94
somaz94 marked this pull request as ready for review July 20, 2026 08:25
@somaz94
somaz94 requested a review from a team as a code owner July 20, 2026 08:25
@robholland robholland self-assigned this Jul 27, 2026
@robholland
robholland merged commit 1bac867 into temporalio:main Jul 27, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants