iterator includes tests - #5031
Merged
Merged
Conversation
bakkot
reviewed
Apr 16, 2026
bakkot
left a comment
Member
There was a problem hiding this comment.
some nits but looks reasonably complete
Member
Author
|
@bakkot Feedback addressed. |
bakkot
reviewed
Apr 18, 2026
bakkot
approved these changes
Apr 21, 2026
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Apr 24, 2026
These are from tc39/test262#5031 which is currently under review. Once the tests land upstream, these can be removed. This will be handled as part of shipping the feature when it reaches Stage 3. Differential Revision: https://phabricator.services.mozilla.com/D295351
Member
Author
|
Added a new commit for tc39/proposal-iterator-includes#15. |
Contributor
|
Would be good to merge this as it's been stage 3 for a few months. |
bakkot
enabled auto-merge (squash)
July 29, 2026 16:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for https://github.com/michaelficarra/proposal-iterator-includes.
Disclaimer: I used AI in the process of creating this PR (using the same process as in #5011, including a full review and minor tweaks).