Add tests for RegExp Buffer Boundaries - #4975
Open
rbuckton wants to merge 11 commits into
Open
Conversation
4 tasks
gibson042
approved these changes
Mar 11, 2026
gibson042
left a comment
Member
There was a problem hiding this comment.
LGTM, pending proposal advancement.
Member
Author
|
Updated per the consensus to add |
gibson042
requested changes
May 21, 2026
gibson042
left a comment
Member
There was a problem hiding this comment.
Please split the files to separate assertions that depend upon feature "regexp-v-flag" from those that do not. See also other suggestions below.
Member
Author
|
Also updated the descriptions for the annex-b identity escape tests |
gibson042
approved these changes
May 21, 2026
gibson042
left a comment
Member
There was a problem hiding this comment.
Looks good, just one final suggestion.
gibson042
approved these changes
May 21, 2026
Member
Author
|
Missed one of the comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for RegExp Buffer Boundaries