update spec, readme to options bag approach - #11
Open
peetklecha wants to merge 6 commits into
Open
Conversation
peetklecha
commented
Aug 4, 2026
acutmore
reviewed
Aug 7, 2026
| 1. Else, | ||
| 1. Return _unfiltered_. | ||
| 1. Let _jsonString_ be ? ToString(_text_). | ||
| 1. <ins>Let _options_ be CreateJSONParseOptionsRecord(_reviver_)</ins>. |
Collaborator
There was a problem hiding this comment.
Suggested change
| 1. <ins>Let _options_ be CreateJSONParseOptionsRecord(_reviver_)</ins>. | |
| 1. <ins>Let _options_ be CreateJSONParseOptions(_reviver_)</ins>. |
| 1. Let _preferNullPrototypeChoice_ be *undefined*. | ||
| 1. If _options_ ? <emu-meta suppress-effects="user-code">HasProperty(_options_, *"freeze"*)</emu-meta>, then | ||
| 1. Let _freezeChoice_ be ? <emu-meta suppress-effects="user-code">Get(_options_, *"freeze"*)</emu-meta>. | ||
| 1. If _freezeChoice_ is not a Boolean and _freezeChoice_ is not *undefined*, throw a *TypeError* exception. |
Collaborator
There was a problem hiding this comment.
I think the more general convention for boolean options is to coerce https://github.com/tc39/how-we-work/blob/main/normative-conventions.md#avoid-coercing-arguments-to-types-other-than-boolean
This is also what Temporal does for options, it calls ToBoolean: https://tc39.es/proposal-temporal/#sec-getoption
| </emu-alg> | ||
| <p>This function is the <dfn>%JSONParseImmutable%</dfn> intrinsic object.</p> | ||
| <p>The *"length"* property of the `parseImmutable` function is 2.</p> | ||
| <emu-table id="table-json-parse-options-records" caption="JSON Parse Options Record Fields"> |
Collaborator
There was a problem hiding this comment.
This section should be in a emu-cause that defines a "JSON Parse Options Record". That way the other parts of the spec that say that return or take this type can properly reference it.
Example for reference:https://github.com/tc39/proposal-composites/blob/d667368b05fbc11b60e678ca13b7b0b394bcc8be/spec.emu#L177-L181
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.