Skip to content

841 enhancement rename datasource#843

Merged
shinchris merged 4 commits into
tableau:developmentfrom
annematronic:841-enhancement-rename-datasource
May 25, 2021
Merged

841 enhancement rename datasource#843
shinchris merged 4 commits into
tableau:developmentfrom
annematronic:841-enhancement-rename-datasource

Conversation

@annematronic

@annematronic annematronic commented May 5, 2021

Copy link
Copy Markdown
Contributor

Changes include:

  • Update request factory to add name attribute when present.
  • Update Datasource tests to assert name (and some other properties that were not already asserted)
  • Updated other Datasource tests which were passing 'project_id' and 'name' in the incorrect order to the DatasourceItem constructor

shinchris
shinchris reviewed May 24, 2021
View reviewed changes

@shinchris shinchris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment in test, but otherwise looks good!

Comment thread test/test_datasource.py Outdated
@shinchris shinchris merged commit 5d333f5 into tableau:development May 25, 2021
vchavatapalli pushed a commit to vchavatapalli/server-client-python that referenced this pull request May 5, 2026
@annematronic
841 enhancement rename datasource (tableau#843)
524cebd 
* Add support for rename datasource

* remove erroneous sys.path line

* remove sys import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shinchris shinchris shinchris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla:signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@annematronic @shinchris @jacalata