Skip to content

BugFix Issue#79 Add Guest to site role enum#83

Merged
t8y8 merged 1 commit into
tableau:developmentfrom
Kovner:bugfix-issue79-guestuser
Oct 27, 2016
Merged

BugFix Issue#79 Add Guest to site role enum#83
t8y8 merged 1 commit into
tableau:developmentfrom
Kovner:bugfix-issue79-guestuser

Conversation

@Kovner

@Kovner Kovner commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

Fixes issue where Guest user was not a valid user_item

@Kovner

Kovner commented Oct 27, 2016

Copy link
Copy Markdown
Contributor Author

bitmoji

@t8y8

t8y8 commented Oct 27, 2016

Copy link
Copy Markdown
Collaborator

We don't currently have validating tests for the 'positive' cases on the model (we only test invalid cases :'( ) so I'm ok with this one-liner IF you promise it fixed the issue for you in a manual run.

Or, include a screenshot? <3

@Kovner

Kovner commented Oct 27, 2016

Copy link
Copy Markdown
Contributor Author

The bitmoji of me Nailing it wasn't sufficient?

image

image

@t8y8 t8y8 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@LGraber

LGraber commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

🚀

@t8y8 t8y8 merged commit 2f041d1 into tableau:development Oct 27, 2016
bryceglarsen pushed a commit to bryceglarsen/server-client-python that referenced this pull request Dec 28, 2023
bryceglarsen pushed a commit to bryceglarsen/server-client-python that referenced this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants