[FrameworkBundle] Make ConfigDebugCommand use its container to resolve env vars
#62681
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
requested changes
Dec 7, 2025
src/Symfony/Bundle/FrameworkBundle/Command/ConfigDebugCommand.php
Outdated
Show resolved
Hide resolved
152c237 to
1581035
Compare
Member
|
Is there a way to test this fix? |
Contributor
Author
Couldn’t figure out how; looks like the issue also impact functional tests 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConfigDebugCommandcurrently cannot use theSodiumVaultto load env vars because its$secretsDirdepends on one, so calling it with--resolve-env-varsfails if an env var is only present in the vault. I’m not sure if it’s for the same reason but compiling the container with$resolveEnvPlaceholderssuffers from the same issue.I didn’t find a way to fix this so this PR works around it by setting the new container’s env var processors as the command’s so that the vault (and anything that could be used to resolve env vars) is correctly initialized.