[JsonStreamer] fix invalid json output for list of self #62622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
symfony/json-streamercomponent on an object which contains a list of self (list<int, self>,self[]) generates invalid JSON.This happens because the generated code does not yield a comma (
,) for the first entry in the list and instead outputs an additional comma at the end of the list.A class like:
Currently outputs invalid JSON:
{"dummies":[{"dummies":[]}{"dummies":[]},{"dummies":[]},]}This PR fixes the above example to output valid JSON:
{"dummies":[{"dummies":[]},{"dummies":[]},{"dummies":[]}]}