[PropertyInfo] treat simple arrays of mixed values as arrays not as lists #62546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17c1b34 to
a01284b
Compare
Spomky
approved these changes
Nov 29, 2025
a01284b to
8b3d215
Compare
Member
Author
|
Status: Needs work |
8b3d215 to
21cbbb3
Compare
21cbbb3 to
9f14fea
Compare
xabbuh
commented
Nov 29, 2025
| ['mixedCollection', [new Type(Type::BUILTIN_TYPE_ARRAY, false, null, true, null, null)], null, null], | ||
| ['collection', [new Type(Type::BUILTIN_TYPE_ARRAY, false, null, true, [new Type(Type::BUILTIN_TYPE_INT), new Type(Type::BUILTIN_TYPE_STRING)], new Type(Type::BUILTIN_TYPE_OBJECT, false, 'DateTimeImmutable'))], null, null], | ||
| ['nestedCollection', [new Type(Type::BUILTIN_TYPE_ARRAY, false, null, true, [new Type(Type::BUILTIN_TYPE_INT), new Type(Type::BUILTIN_TYPE_STRING)], new Type(Type::BUILTIN_TYPE_ARRAY, false, null, true, [new Type(Type::BUILTIN_TYPE_INT), new Type(Type::BUILTIN_TYPE_STRING)], new Type(Type::BUILTIN_TYPE_STRING, false)))], null, null], | ||
| ['mixedCollection', [new Type(Type::BUILTIN_TYPE_ARRAY, false, null, true, [new Type(Type::BUILTIN_TYPE_INT), new Type(Type::BUILTIN_TYPE_STRING)], null)], null, null], |
Member
Author
There was a problem hiding this comment.
@mtarld and me talked about the failures during the hackathon. What we would have preferred as the solution is changing only this line to:
Suggested change
| ['mixedCollection', [new Type(Type::BUILTIN_TYPE_ARRAY, false, null, true, [new Type(Type::BUILTIN_TYPE_INT), new Type(Type::BUILTIN_TYPE_STRING)], null)], null, null], | |
| ['mixedCollection', [new Type(Type::BUILTIN_TYPE_ARRAY, false, null, true, new Type(Type::BUILTIN_TYPE_INT), null)], null, null], |
That would mean not having to do any changes to prepare for the next phpdocumentor/type-resolver release and would also mean to be consistent with the other collection examples.
However, I found no way to distinguish mixed[] and array on released versions of that package meaning that we would have to bump constraint to have consistently passing tests.
Now, we can get the CI green by enforcing that the key type for arrays is int|string which is technically correct but may break existing code that relies on the key being null. I am not sure how we want to proceed here (if we are fine with the current solution, we should probably align the other extractors).
Member
Author
There was a problem hiding this comment.
looks like I found a way to restore the previous (even if not fully correct) behaviour, see #62577 as an alternative (now checking if we can achieve the same for 7.3+ when we use the TypeInfo component under the hood)
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Nov 29, 2025
This fixes the PropertyInfo component tests by treating `mixed[]` as an alias of `array` sticking with the current behaviour even if that may technically not be fully correct to avoid unwanted behaviour changes for existing applications (see symfony#62546 (comment)).
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Nov 29, 2025
This fixes the PropertyInfo component tests by treating `mixed[]` as an alias of `array` sticking with the current behaviour even if that may technically not be fully correct to avoid unwanted behaviour changes for existing applications (see symfony#62546 (comment)).
fabpot
added a commit
that referenced
this pull request
Nov 29, 2025
…tting types from docblocks (xabbuh) This PR was merged into the 6.4 branch. Discussion ---------- [PropertyInfo] treat `mixed[]` the same as `array` when getting types from docblocks | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | account for phpDocumentor/TypeResolver#237 | License | MIT This fixes the PropertyInfo component tests by treating `mixed[]` as an alias of `array` sticking with the current behaviour even if that may technically not be fully correct to avoid unwanted behaviour changes for existing applications (see #62546 (comment)). Commits ------- 2d94451 treat `mixed[]` the same as `array` when getting types from docblocks
symfony-splitter
pushed a commit
to symfony/property-info
that referenced
this pull request
Nov 29, 2025
This fixes the PropertyInfo component tests by treating `mixed[]` as an alias of `array` sticking with the current behaviour even if that may technically not be fully correct to avoid unwanted behaviour changes for existing applications (see symfony/symfony#62546 (comment)).
Member
Author
|
closing as #62577 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test suite is currently failing because of what has been done in phpDocumentor/TypeResolver#237. The changed behaviour reminds me of #62388 look reasonable to me.
We need to decide if we want to bump the conflict (we cannot merge yet then as the latest tagged release is 1.12.0) or if we prefer to kind of implement the require logic for older versions of
phpdocumentor/type-resolverourselves inPhpDocTypeHelper::createType().