[HttpKernel] Make #[Cache] respect all explicit cache directives set in controller
#62488
+45
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
The previous controller will result :
Cache-Control : max-age=300, publicinstead of :
Cache-Control : max-age=300, private, no-storeController-defined directives (private, no-store) were lost, which is unexpected and it limits the flexibility of controller-level cache control.
The
#[Cache]is meant for defining default values and shouldn't override the controller.Even the
ResponseHeaderBag::computeCacheControlValue()respects explicit visibility but the#[Cache]doesn'tAfter:
Note
This PR does not change the default behavior of computed cache headers. The
#[Cache]attribute can still override the default values, only explicitly defined controller directives take precedence.