[DependencyInjection] Fix loop corruption in CheckTypeDeclarationsPass
#62485
+22
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheckTypeDeclarationsPass
OskarStark
reviewed
Nov 23, 2025
src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckTypeDeclarationsPassTest.php
Show resolved
Hide resolved
4810638 to
3866ff1
Compare
Member
|
Thank you @yoeunes. |
Merged
This was referenced Dec 7, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
CheckTypeDeclarationsPass, the loop counter$iwas incorrectly overwritten with the parameter name when processing named arguments.Comparing a string to an integer here (e.g.
'b' < 2) evaluates tofalse. This caused the loop to terminate early, skipping type validation for all subsequent arguments.