[DependencyInjection] Fix loose validation in #[Autowire] attribute
#62482
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ed0e29 to
765cd5f
Compare
OskarStark
reviewed
Nov 22, 2025
src/Symfony/Component/DependencyInjection/Tests/Attribute/AutowireTest.php
Show resolved
Hide resolved
765cd5f to
c9fda09
Compare
#[Autowire] attribute
stof
approved these changes
Nov 23, 2025
src/Symfony/Component/DependencyInjection/Attribute/Autowire.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Attribute/AutowireTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Attribute/AutowireTest.php
Outdated
Show resolved
Hide resolved
c9fda09 to
f0a2f56
Compare
xabbuh
approved these changes
Nov 26, 2025
fabpot
approved these changes
Nov 29, 2025
Member
|
Thank you @yoeunes. |
This was referenced Dec 7, 2025
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Autowireattribute uses a chain ofxorconditions to ensure that only one of$value,$service,$expression,$env, or$paramis passed.However,
xoris pairwise associative. If three of these arguments are passed, the expression evaluates totrue((true ^ true) ^ true === true), and the validation passes incorrectly.