[Console] Fix completion for global options values #62416
Merged
+20
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
approved these changes
Nov 16, 2025
OskarStark
reviewed
Nov 17, 2025
nicolas-grekas
approved these changes
Nov 17, 2025
OskarStark
approved these changes
Nov 17, 2025
fabpot
approved these changes
Nov 20, 2025
Member
fabpot
left a comment
There was a problem hiding this comment.
It looks like a new feature to me and should probably target 8.1 instead.
Member
Author
|
@fabpot The reason I considered this a bug is that the current behavior works in some cases but not in others. As mentioned in the description, when the command name is present, everything works as expected. So it feels broken when it doesn't work without one. |
Member
|
Thank you @HypeMC. |
This was referenced Nov 21, 2025
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, completion values for global options aren't displayed when the command name is not specified: