[Filesystem] Unify logic for isAbsolute() in Path #62283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 3, 2025
4e43c84 to
6c9cc87
Compare
Contributor
Author
|
Hi @nicolas-grekas, done - docblocks aligned as suggested! Thank you. |
Member
|
Thank you @yoeunes. |
This was referenced Nov 6, 2025
Merged
Merged
Merged
alexandre-daubois
added a commit
that referenced
this pull request
Nov 19, 2025
This PR was merged into the 7.3 branch. Discussion ---------- Add missing Path class required for `link` tool | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT After #62283, the `Path` class becomes a new requirement for the `link` tool. Current error: ```bash Fatal error: Uncaught Error: Class "Symfony\Component\Filesystem\Path" not found in src/Symfony/Component/Filesystem/Filesystem.php:583 ``` Commits ------- 4465ec9 Add missing Path class required for `link` tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug and removes duplicated code between
Filesystem::isAbsolutePath()andPath::isAbsolute().These two methods had different implementations. The logic in
Pathincorrectly reported stream wrappers (http://,vfs://) and paths likeC:css/style.cssas being relative.This PR makes
Path::isAbsolute()the single source of truth by adopting the more robust logic fromFilesystem.Filesystem::isAbsolutePath()now delegates to it.Note on Path Class Scope
This change ensures
isAbsolute()correctly handles stream wrappers. This is consistent with the component's scope, as other methods likecanonicalize()already support and preserve schemes (e.g.,phar://).