[HttpClient] Remove support for HTTP/2 PUSH #62276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98076b0 to
1b179d6
Compare
yoeunes
reviewed
Nov 2, 2025
1b179d6 to
f98ce06
Compare
Member
Author
|
|
f98ce06 to
55b439b
Compare
Member
Author
nicolas-grekas
added a commit
that referenced
this pull request
Nov 3, 2025
This PR was merged into the 6.4 branch. Discussion ---------- [HttpClient] Reject 3xx pushed responses | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #62279 and #62276 | License | MIT I figured out we could reject 3xx pushed responses to fix the linked issues. This makes #62279 unnecessary. Commits ------- ccdf3cb [HttpClient] Reject 3xx pushed responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP/2 PUSH is a deprecated feature of the protocol. Browsers moved away from it in favor of 103 early hints. Server-side support is quite low in various languages, and use cases are even lower. The vulcain protocol by @dunglas is designed to leverage it, and that's the only use case I'm aware of on the server-side. Yet even in vulcain it's optional.
IMHO, we don't need any deprecation layer. We can just drop supporting it. This won't change anything in practice.
Submitting for 7.4 so that we won't maintain this any longer.