[Validator] remove support for implicit constraint option names in YAML/XML mapping files #61851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 26, 2025
| Q | A |
|---|---|
| Branch? | 8.0 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Issues | |
| License | MIT |
7b9cb1b to
0603ac2
Compare
Member
|
Thank you @xabbuh. |
stof
reviewed
Sep 26, 2025
|
|
||
| foreach ($nodes as $node) { | ||
| if (\count($node) > 0) { | ||
| if (\count($node->value) > 0) { |
Member
There was a problem hiding this comment.
The XSD should also be updated to remove <value> as an allowed child of <constraint>
nicolas-grekas
added a commit
that referenced
this pull request
Sep 26, 2025
This PR was merged into the 8.0 branch. Discussion ---------- [Validator] clean up the XML schema definition | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | see #61851 (comment) | License | MIT Commits ------- c5b8bad clean up the XML schema definition
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.