[Messenger] Add MessageSentToTransportsEvent
#61843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
that referenced
this pull request
Oct 20, 2025
This PR was merged into the 7.4 branch. Discussion ---------- [Messenger] Simplify code | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Noticed while working on #61843. There's no reason for the event to be dispatched inside the loop anymore: 1. The event was [originally dispatched outside the loop](#30650). 2. It was later [moved inside the loop](#30676) because of the retry mechanism. 3. [The retry mechanism was later extracted](#34185), so there's no longer a need for the event to be dispatched inside the loop. Commits ------- beeb4b9 [Messenger] Simplify code
5d48257 to
406a4cc
Compare
Member
|
Thank you @HypeMC. |
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
MessageSentToTransportsEvent, that is dispatched only after a message was sent to at least one transport. This can be useful, for example, for additional monitoring.