[Validator] deprecate implicit constraint option names in YAML/XML mapping files #61791
+150
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
the failures look related Status: Needs Work |
GromNaN
reviewed
Sep 22, 2025
Member
GromNaN
left a comment
There was a problem hiding this comment.
Could you also add tests for the deprecated feature?
53ed983 to
f6a14b0
Compare
Member
Author
|
@GromNaN done |
GromNaN
approved these changes
Sep 24, 2025
| callback: [Symfony\Component\Validator\Tests\Fixtures\CallbackClass, callback] | ||
| ``` | ||
| After: |
Member
There was a problem hiding this comment.
before /after are inverted, isn't it?
stof
reviewed
Sep 24, 2025
UPGRADE-7.4.md
Outdated
|
|
||
| ```xml | ||
| <class name="Symfony\Component\Validator\Tests\Fixtures\NestedAttribute\Entity"> | ||
| <option name="callback"> |
Member
There was a problem hiding this comment.
This is missing the <constraint name="Callback"> tag
UPGRADE-7.4.md
Outdated
| ```yaml | ||
| Symfony\Component\Validator\Tests\Fixtures\NestedAttribute\Entity: | ||
| constraints: | ||
| - Callback: validateMeStatic |
Member
There was a problem hiding this comment.
this is swapping the before and after cases
|
|
||
| ```xml | ||
| <class name="Symfony\Component\Validator\Tests\Fixtures\NestedAttribute\Entity"> | ||
| <option name="callback"> |
Member
There was a problem hiding this comment.
This is missing the <constraint name="Callback"> tag
Member
Author
|
changelog and upgrade file fixed |
Member
|
Thank you @xabbuh. |
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.