[Notifier][Twilio] WhatsApp number validation #61777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Contributor
|
This is a new feature and must target 7.4 branch |
0405f48 to
3697181
Compare
Member
|
Please also add an entry to the changelog file of the Twilio bridge to mention the added support for the WhatsApp API. |
3697181 to
58aea89
Compare
stof
reviewed
Sep 17, 2025
src/Symfony/Component/Notifier/Bridge/Twilio/TwilioTransport.php
Outdated
Show resolved
Hide resolved
58aea89 to
f7d01a6
Compare
xabbuh
reviewed
Sep 17, 2025
f7d01a6 to
b23417d
Compare
xabbuh
reviewed
Sep 17, 2025
b23417d to
5012dc0
Compare
xabbuh
approved these changes
Sep 17, 2025
This commit modifies the validation regex to handle 'whatsapp:' prefixes. The regex now correctly validates WhatsApp numbers without breaking existing functionality for standard phone numbers.
5012dc0 to
b64f285
Compare
fabpot
approved these changes
Sep 18, 2025
Member
|
Thank you @OvidiuGi. |
abdellahrk
pushed a commit
to abdellahrk/symfony
that referenced
this pull request
Sep 18, 2025
…OvidiuGi) This PR was merged into the 7.4 branch. Discussion ---------- [Notifier][Twilio] WhatsApp number validation | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | Fix symfony#61776 | License | MIT This commit modifies the validation regex to handle 'whatsapp:' prefixes. The regex now correctly validates WhatsApp numbers without breaking existing functionality for standard phone numbers. See - [https://github.com/symfony/symfony/issues/61776](url) Commits ------- b64f285 fix: WhatsApp number validation
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modifies the validation regex to handle 'whatsapp:' prefixes. The regex now correctly validates WhatsApp numbers without breaking existing functionality for standard phone numbers.
See