[DependencyInjection] Allow `Class::function(...)` and `global_function(...)` closures in PHP DSL for factories #61656

GromNaN · 2025-09-05T09:03:33Z

Q	A
Branch?	7.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	-
License	MIT

For static class methods:

  $container->services()
      ->set('date', DateTime::class)
-         ->factory([DateTime::class, 'createFromFormat'])
+         ->factory(DateTime::createFromFormat(...))
          ->args(['d/m/Y', env('DATE')])

For global functions:

  $container->services()
      ->set('date', DateTime::class)
-         ->factory('date_create')
+         ->factory(date_create(...))
          ->args(['d/m/Y', env('DATE')])

Copilot

Pull Request Overview

This PR adds support for PHP 8.1+ first-class callable syntax in the Dependency Injection component's PHP DSL for factories. It allows using Class::method(...) and global_function(...) closures instead of array/string notation for factory definitions.

Extends the factory() method to accept \Closure parameters
Adds validation to ensure closures are first-class callables (not anonymous or bound)
Converts closures to appropriate factory formats internally

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php	Adds closure support with validation and conversion logic
src/Symfony/Component/DependencyInjection/Tests/Fixtures/config/services9.php	Updates test fixture to use new first-class callable syntax

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php

nicolas-grekas

Nice one! Don't forget about configurators ;)

src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php

GromNaN

Don't forget about configurators ;)

Could you point me in the direction of what else needs to be changed?

For tests, would you add new fixture.php files? I think unit tests would be fine.

src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php

nicolas-grekas · 2025-09-05T09:45:56Z

src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/ConfiguratorTrait.php
src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FromCallableTrait.php
src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php (the closure function)

I'd go with a new fixture yes - to cover all these cases

fabpot · 2025-09-06T11:51:12Z

src/Symfony/Component/DependencyInjection/Loader/Configurator/AbstractConfigurator.php

    }
+
+ /**
+     * Convert a named closure to dumpable callable.


Suggested change

* Convert a named closure to dumpable callable.

* Converts a named closure to dumpable callable.

…on(...)` closures in PHP DSL for factories

fabpot · 2025-09-06T11:53:10Z

Thank you @GromNaN.

carsonbot added Status: Needs Review Feature labels Sep 5, 2025

carsonbot added this to the 7.4 milestone Sep 5, 2025

carsonbot changed the title ~~[DependencyInjection Allow Class::function(...) and global_function(...) closures in PHP DSL for factories~~ [DependencyInjection Allow Class::function(...) and global_function(...) closures in PHP DSL for factories Sep 5, 2025

GromNaN changed the title ~~[DependencyInjection Allow Class::function(...) and global_function(...) closures in PHP DSL for factories~~ [DependencyInjection] Allow Class::function(...) and global_function(...) closures in PHP DSL for factories Sep 5, 2025

GromNaN force-pushed the factory-closure branch 2 times, most recently from 3d2d343 to b1c7a25 Compare September 5, 2025 09:08

GromNaN requested a review from Copilot September 5, 2025 09:08

Copilot AI reviewed Sep 5, 2025

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php Outdated Show resolved Hide resolved

src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php Outdated Show resolved Hide resolved

GromNaN force-pushed the factory-closure branch from b1c7a25 to e577498 Compare September 5, 2025 09:09

nicolas-grekas reviewed Sep 5, 2025

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php Outdated Show resolved Hide resolved

nicolas-grekas reviewed Sep 5, 2025

View reviewed changes

GromNaN commented Sep 5, 2025

View reviewed changes

src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php Outdated Show resolved Hide resolved

src/Symfony/Component/DependencyInjection/Loader/Configurator/Traits/FactoryTrait.php Outdated Show resolved Hide resolved

GromNaN mentioned this pull request Sep 5, 2025

[VarExporter] Add support for exporting named closures #61657

Merged

GromNaN force-pushed the factory-closure branch 2 times, most recently from d85b952 to 46b9395 Compare September 5, 2025 17:13

HypeMC approved these changes Sep 5, 2025

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Sep 5, 2025

carsonbot changed the title ~~[DependencyInjection] Allow Class::function(...) and global_function(...) closures in PHP DSL for factories~~ Allow Class::function(...) and global_function(...) closures in PHP DSL for factories Sep 5, 2025

GromNaN changed the title ~~Allow Class::function(...) and global_function(...) closures in PHP DSL for factories~~ [DependencyInjection] Allow Class::function(...) and global_function(...) closures in PHP DSL for factories Sep 6, 2025

fabpot approved these changes Sep 6, 2025

View reviewed changes

[DependencyInjection] Allow Class::function(...) and `global_functi…

cde55c3

…on(...)` closures in PHP DSL for factories

fabpot force-pushed the factory-closure branch from 58526b6 to cde55c3 Compare September 6, 2025 11:53

fabpot merged commit 75935f8 into symfony:7.4 Sep 6, 2025
9 of 12 checks passed

fabpot mentioned this pull request Sep 6, 2025

[DependencyInjection] Allow Class::function(...) and `global_function… symfony/symfony-docs#21349

Open

GromNaN deleted the factory-closure branch September 6, 2025 12:18

fabpot mentioned this pull request Oct 27, 2025

Release v7.4.0-BETA1 #62172

Merged

fabpot mentioned this pull request Oct 27, 2025

Release v8.0.0-BETA1 #62173

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[DependencyInjection] Allow `Class::function(...)` and `global_function(...)` closures in PHP DSL for factories #61656

[DependencyInjection] Allow `Class::function(...)` and `global_function(...)` closures in PHP DSL for factories #61656

Uh oh!

GromNaN commented Sep 5, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GromNaN left a comment

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas commented Sep 5, 2025 •

edited

Loading

Uh oh!

fabpot Sep 6, 2025

Uh oh!

fabpot commented Sep 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	* Convert a named closure to dumpable callable.
	* Converts a named closure to dumpable callable.

Uh oh!

[DependencyInjection] Allow Class::function(...) and global_function(...) closures in PHP DSL for factories #61656

[DependencyInjection] Allow Class::function(...) and global_function(...) closures in PHP DSL for factories #61656

Uh oh!

Conversation

GromNaN commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GromNaN left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fabpot Sep 6, 2025

Choose a reason for hiding this comment

Uh oh!

fabpot commented Sep 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[DependencyInjection] Allow `Class::function(...)` and `global_function(...)` closures in PHP DSL for factories #61656

[DependencyInjection] Allow `Class::function(...)` and `global_function(...)` closures in PHP DSL for factories #61656

GromNaN commented Sep 5, 2025 •

edited

Loading

nicolas-grekas commented Sep 5, 2025 •

edited

Loading