[Form] Add form type guesser for EnumType
#61297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mttsch
commented
Aug 1, 2025
30ce63c to
0796aa4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
80d176c to
78a2346
Compare
1fbb523 to
a5eebb2
Compare
src/Symfony/Component/Form/Tests/Fixtures/EnumFormTypeGuesserCase.php
Outdated
Show resolved
Hide resolved
|
|
||
| private function getPropertyType(string $class, string $property): ?\ReflectionNamedType | ||
| { | ||
| if (isset($this->cache[$class]) && \array_key_exists($property, $this->cache[$class])) { |
Member
There was a problem hiding this comment.
Suggested change
| if (isset($this->cache[$class]) && \array_key_exists($property, $this->cache[$class])) { | |
| if (isset($this->cache[$class][$property])) { |
Comment on lines
57
to
60
| if (!isset($this->cache[$class])) { | ||
| $this->cache[$class] = []; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| if (!isset($this->cache[$class])) { | |
| $this->cache[$class] = []; | |
| } |
| $classReflection = new \ReflectionClass($class); | ||
| $propertyReflection = $classReflection->getProperty($property); | ||
| } catch (\ReflectionException) { | ||
| return $this->cache[$class][$property] = null; |
Member
There was a problem hiding this comment.
Suggested change
| return $this->cache[$class][$property] = null; | |
| return $this->cache[$class][$property] = false; |
Comment on lines
62
to
63
| $classReflection = new \ReflectionClass($class); | ||
| $propertyReflection = $classReflection->getProperty($property); |
Member
There was a problem hiding this comment.
Suggested change
| $classReflection = new \ReflectionClass($class); | |
| $propertyReflection = $classReflection->getProperty($property); | |
| $propertyReflection = new \ReflectionProperty($class, $property); |
Comment on lines
68
to
72
| if (!$propertyReflection->getType() instanceof \ReflectionNamedType || !enum_exists($propertyReflection->getType()->getName())) { | ||
| return $this->cache[$class][$property] = null; | ||
| } | ||
|
|
||
| return $this->cache[$class][$property] = $propertyReflection->getType(); |
Member
There was a problem hiding this comment.
Suggested change
| if (!$propertyReflection->getType() instanceof \ReflectionNamedType || !enum_exists($propertyReflection->getType()->getName())) { | |
| return $this->cache[$class][$property] = null; | |
| } | |
| return $this->cache[$class][$property] = $propertyReflection->getType(); | |
| $type = $propertyReflection->getType(); | |
| if (!$type instanceof \ReflectionNamedType || !enum_exists($enum->getName())) { | |
| $type = false; | |
| } | |
| return $this->cache[$class][$property] = $type; |
a5eebb2 to
1e540eb
Compare
xabbuh
reviewed
Aug 5, 2025
| $container->removeDefinition('form.type_extension.form.html_sanitizer'); | ||
| } | ||
|
|
||
| if (!class_exists(EnumFormTypeGuesser::class)) { |
Member
There was a problem hiding this comment.
I would do this inside registerFormConfiguration()
xabbuh
reviewed
Aug 5, 2025
xabbuh
reviewed
Aug 5, 2025
1e540eb to
dc492c9
Compare
Contributor
Author
|
@nicolas-grekas @xabbuh Is there anything more to do for me in this PR? |
xabbuh
reviewed
Aug 22, 2025
dc492c9 to
7918e76
Compare
xabbuh
reviewed
Aug 27, 2025
xabbuh
approved these changes
Aug 27, 2025
7918e76 to
9e8a923
Compare
fabpot
approved these changes
Aug 30, 2025
Member
|
Thank you @mttsch. |
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new form type guesser guesses the form type of an enum property and also sets the
classoption of theEnumTypeto the relevant enum name.