Skip to content

[Serializer] remove return type from AbstractObjectNormalizer::getAllowedAttributes() #60958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xabbuh merged 1 commit into from
Jun 30, 2025
Merged

[Serializer] remove return type from AbstractObjectNormalizer::getAllowedAttributes() #60958

xabbuh merged 1 commit into from
Jun 30, 2025

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Jun 30, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #60957
License MIT

@xabbuh xabbuh requested a review from dunglas as a code owner June 30, 2025 07:29
@carsonbot carsonbot added this to the 6.4 milestone Jun 30, 2025
@xabbuh xabbuh mentioned this pull request Jun 30, 2025
Closed
@OskarStark OskarStark changed the title [Serializer] remove return type from AbstractObjectNormalizer::getAllowedAttributes() [Serializer] remove return type from AbstractObjectNormalizer::getAllowedAttributes() Jun 30, 2025
@stof
Copy link
Member

stof commented Jun 30, 2025

will need to be reverted in the 8.0 branch

@xabbuh xabbuh merged commit bd60612 into symfony:6.4 Jun 30, 2025
9 of 11 checks passed
@xabbuh xabbuh deleted the issue-60957 branch June 30, 2025 11:29
@OskarStark
Copy link
Contributor

OskarStark commented Jun 30, 2025

will need to be reverted in the 8.0 branch

do you create a PR @xabbuh ?

@xabbuh
Copy link
Member Author

xabbuh commented Jun 30, 2025

will need to be reverted in the 8.0 branch

do you create a PR @xabbuh ?

yes

@xabbuh
Copy link
Member Author

xabbuh commented Jul 1, 2025

reverted in 0fdec91 when merging up

santysisi pushed a commit to santysisi/symfony that referenced this pull request Jul 2, 2025
@xabbuh @santysisi
bug symfony#60958 [Serializer] remove return type from `AbstractObjec…
136e6cb 
…tNormalizer::getAllowedAttributes()` (xabbuh)

This PR was merged into the 6.4 branch.

Discussion
----------

[Serializer] remove return type from `AbstractObjectNormalizer::getAllowedAttributes()`

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Fix symfony#60957
| License       | MIT

Commits
-------

b58fa26 remove return type from AbstractObjectNormalizer::getAllowedAttributes()
@welcoMattic welcoMattic added the BC Layer removal Used to track BC layer removals before a major release label Jul 4, 2025
@xabbuh xabbuh mentioned this pull request Jul 4, 2025
Closed
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull request Jul 7, 2025
@christopherhero
fix symfony/symfony#60958
3d2a858
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull request Jul 7, 2025
@christopherhero
fix github.com/symfony/symfony/pull/60958
5340e76
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull request Jul 7, 2025
@christopherhero
fix github.com/symfony/symfony/pull/60958
3c1772e
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull request Jul 7, 2025
@christopherhero
fix github.com/symfony/symfony/pull/60958
4245ab6
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull request Jul 7, 2025
@christopherhero
fix github.com/symfony/symfony/pull/60958
626e5b7
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull request Jul 7, 2025
@christopherhero
fix github.com/symfony/symfony/pull/60958
8c5fb1d
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull request Jul 7, 2025
@christopherhero
fix github.com/symfony/symfony/pull/60958
380f80f
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull request Jul 7, 2025
@christopherhero
fix github.com/symfony/symfony/pull/60958
8384dbf
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull request Jul 7, 2025
@christopherhero
fix github.com/symfony/symfony/pull/60958
379e6be
christopherhero added a commit to BitBagCommerce/SyliusBannerPlugin that referenced this pull request Jul 7, 2025
@christopherhero
fix github.com/symfony/symfony/pull/60958
ac62b0d
This was referenced Jul 31, 2025
Merged
Merged
Merged
@Jibbarth Jibbarth mentioned this pull request Aug 14, 2025
Merged
TheMilek added a commit to Sylius/Sylius that referenced this pull request Aug 20, 2025
@TheMilek
[Composer][1.14] More specific confflict with serializer (#18302)
ebf70b4 
| Q               | A
|-----------------|-----
| Branch?         | 1.14
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | #18195 
| License         | MIT

The bug raised in #18195 as been revert in symfony/serializer in 6.4.24
(cf symfony/symfony#60958)

I guess we can target the conflict only on 6.4.23 now.
@renovate renovate bot mentioned this pull request Sep 27, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof stof approved these changes

@HypeMC HypeMC HypeMC approved these changes

@mtarld mtarld mtarld approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees

No one assigned

Labels

BC Layer removal Used to track BC layer removals before a major release Bug Serializer Status: Reviewed

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

7 participants

@xabbuh @stof @OskarStark @HypeMC @mtarld @welcoMattic @carsonbot