Now after updating some related tests, I'm concerned that this might break some functional tests out there (after upgrading to 7.3) for example: testing HTML error pages using WebTestCase won't work anymore if these tests are checking for more than just the error message.

Should we consider this a BC break?

Hi,

Thanks, it looks good to me at first glance.
I'll test it on my side to see how it behaves.

testing HTML error pages using WebTestCase won't work anymore if these tests are checking for more than just the error message.

Is there a way to opt-in for this feature (e.g. a dedicated env var)?

testing HTML error pages using WebTestCase won't work anymore if these tests are checking for more than just the error message.

Is there a way to opt-in for this feature (e.g. a dedicated env var)?

This small change restores the previous behavior. We could document this adjustment for situations where you specifically want to test the actual HTML error page:

-    ->alias('error_renderer.default', 'error_handler.error_renderer.default')
+    ->alias('error_renderer.default', 'error_renderer.html')

Most functional/end-to-end tests have a dedicated config file. That could be better than using an env var, since you can enable or disable this behavior case by case.

Or we could add a new framework option to opt-in for this behavior, include a deprecation notice to make it the default in 8.0, and update the recipe file to set it as the default for new projects. What do you think?

Sounds good 👍

support 👍

Still pending on my side to add the deprecation notice to make the new option defaults to true in 8.0. + a new recipe to set it to true for 7.4 (new projects)

Test failure on php_errors_log_levels.yml is a false-positive.

  # Check YAML files for syntax errors
  rm -rf b && cp -a a b && cd b
  find . -name '*.yml' -o -name '*.yaml' \
    | while read -r FILE; do php -r '
      use Symfony\Component\Yaml\{Parser,Yaml};
      require $_SERVER["HOME"]."/.composer/vendor/autoload.php";
      try { (new Parser())->parse(file_get_contents($argv[1]), Yaml::PARSE_CUSTOM_TAGS); }
      catch (Exception $e) { echo "::error::in $argv[1]:\n{$e->getMessage()}\n"; exit(1); }
    ' "$FILE"
    done
  cd ..
  shell: /usr/bin/bash -e {0}
  env:
    GH_TOKEN: ***
Error: in ./src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Fixtures/yml/php_errors_log_levels.yml:
Non-string keys are not supported. Quote your evaluable mapping keys instead at line 8 (near "!php/const \E_NOTICE: !php/const Psr\Log\LogLevel::ERROR").

@symfony/mergers This PR is ready for 7.4

Now with the last suggestion I think the option can be removed as ppl will have the APP_RUNTIME_MODE to switch when they need it.

I will do the changes so we can merge this in 7.4, is it ok for you @nicolas-grekas ?

Thank you @yceruto.

As anticipated by @yceruto this breaks some of our functional tests. It can be bypassed by passing ['APP_RUNTIME_MODE' => 'web=1'] to the FunctionalTest::createClient, but I'm not sure this is/was intended in a minor version?

As anticipated by @yceruto this breaks some of our functional tests. It can be bypassed by passing ['APP_RUNTIME_MODE' => 'web=1'] to the FunctionalTest::createClient, but I'm not sure this is/was intended in a minor version?

Could you please share the whole code to set APP_RUNTIME_MODE properly? I can’t find a way to make it work.

Update: I put it in phpunit.xml.dist and it worked.

  <php>
    <env name="APP_RUNTIME_MODE" value="web=1"/>
  </php>